pytester: _makefile: use abs=True when joining paths
#6578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing in an absolute path should use that, but not join it with the tmpdir.
|
I wonder if we should extend/patch |
RonnyPfannschmidt
requested changes
Jan 26, 2020
| @@ -614,7 +614,7 @@ def to_text(s): | |||
|
|
|||
| ret = None | |||
| for basename, value in items: | |||
| p = self.tmpdir.join(basename).new(ext=ext) | |||
| p = self.tmpdir.join(basename, abs=True).new(ext=ext) | |||
There was a problem hiding this comment.
this is a breaking change that opens up badly made test suites to accidentally writing system wide files
the pathlib behaviour is a security nightmare as is
There was a problem hiding this comment.
@RonnyPfannschmidt
So what changes do you request then actually?
The use case here is using testdir.makepyfile with an absolute file - do you think this should not be supported then?
There was a problem hiding this comment.
Testing the current behavior in #6579.
There was a problem hiding this comment.
The current behavior fails on Windows:
OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw1\test_makefile_joins_absolute_path0\C:'
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 26, 2020
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 26, 2020
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 27, 2020
2 tasks
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 28, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 28, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 28, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 28, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 30, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 30, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 13, 2020
This is a sane method to create a set of files, allowing for absolute paths. Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 17, 2020
This is a simple, straight-forward method to create a set of files with different extensions, and handling absolute paths (inside of the tmpdir). Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 18, 2020
This is a simple, straight-forward method to create a set of files with different extensions, and handling absolute paths (inside of the tmpdir). Ref: pytest-dev#6578 Ref: pytest-dev#6579
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 18, 2020
This is a simple, straight-forward method to create a set of files with different extensions, and handling absolute paths (inside of the tmpdir). Ref: pytest-dev#6578 Ref: pytest-dev#6579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing in an absolute path should use that, but not join it with the
tmpdir.
TODO: