require codecov patch % to be 100% #13273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Mar 5, 2025
|
I recall in the past we did not use this configuration because codecov was proving to be unreliable, but that was many years ago so let's hope the experience is better this time. 🤞 |
|
It's much more stable these days, yes. |
|
It's possible to bypass with admin rights (for exemple if you remove a bunch of well covered code the coverage percentage decrease and it's ok). |
|
I think even with unreliable codecov there's rarely gonna be difference between 96.87% and 100%, and yeah it's possible to override or rerun failed uploads. But 🤞 indeed |
|
#12017 just demonstrated this is a good idea there was stuff i actually missed - and before it would have missed also im under the impression sentry is slowly getting codecov better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status quo is for patch coverage to be greater than or equal to the project% (currently 96.87%), which means that in practice it's 100% .. except if a PR is big enough, at which point a couple lines can sneak through.
I just merged #13192 which had 98.26% coverage for no reason, I'll add more tests and stuff in a followup to retroactively get it to 100%.