Skip to content

Conversation

@moajo
Copy link
Contributor

@moajo moajo commented Oct 7, 2024

Closes #9037 .
The additional test cases were implemented in almost the same way as the existing similar test cases.

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.
  • Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.
  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Oct 7, 2024
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this

as the option is intentionally foot-gun named i consider this as not a breaking change, but that is very debatable and i want to get input from the others

Co-authored-by: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is a breaking change at all, as it is a bugfix because clearly the option should have been considered also for parametrized test ids.

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
@RonnyPfannschmidt
Copy link
Member

Its kind of a breaking change as we inadvertedly change test ids of affected tests

@nicoddemus nicoddemus enabled auto-merge (squash) October 9, 2024 20:37
@nicoddemus nicoddemus merged commit a14c718 into pytest-dev:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parametrized tests don't display unicode in ids correctly.

3 participants