Skip to content

assorted code updates and f string migrations #12017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Feb 21, 2024

  • junitxml fstrings
  • skipping fstrings
  • fixture test fstrings
  • junitxml tests Domnode Refactoring (needs bikeshedding)

this is a bunch of changes i collected as i wanted to start redoing #10997

depends on #12501

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny-ruff-upgrade branch 4 times, most recently from f699e64 to fd3ee18 Compare June 21, 2024 10:10
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 21, 2024
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Jun 21, 2024
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple of questions and suggestions.

@RonnyPfannschmidt RonnyPfannschmidt marked this pull request as ready for review July 8, 2024 08:42
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor suggestions, otherwise LGTM.

@RonnyPfannschmidt RonnyPfannschmidt added this to the 8.4 milestone Nov 12, 2024
@nicoddemus
Copy link
Member

@RonnyPfannschmidt can you fix the conflicts and perhaps go ahead and merge this?

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the ronny-ruff-upgrade branch 2 times, most recently from 3a35b47 to dc875f8 Compare March 10, 2025 14:19
@RonnyPfannschmidt RonnyPfannschmidt merged commit d149ab3 into pytest-dev:main Mar 11, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in pytest sprint 2024 Mar 11, 2025
@RonnyPfannschmidt RonnyPfannschmidt deleted the ronny-ruff-upgrade branch March 11, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants