-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
assorted code updates and f string migrations #12017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assorted code updates and f string migrations #12017
Conversation
f699e64
to
fd3ee18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of questions and suggestions.
77d991c
to
7a30d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor suggestions, otherwise LGTM.
a2bb28b
to
5e7f914
Compare
124d9cc
to
43e7011
Compare
@RonnyPfannschmidt can you fix the conflicts and perhaps go ahead and merge this? |
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
3a35b47
to
dc875f8
Compare
dc875f8
to
f5de7c1
Compare
this is a bunch of changes i collected as i wanted to start redoing #10997
depends on #12501