Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkInfo class is misused for collection of MarkInfo objects #886

Closed
JanBednarik opened this issue Jul 25, 2015 · 4 comments
Closed

MarkInfo class is misused for collection of MarkInfo objects #886

JanBednarik opened this issue Jul 25, 2015 · 4 comments
Labels
topic: marks related to marks, either the general marks or builtin

Comments

@JanBednarik
Copy link
Contributor

MarkInfo class ( https://github.com/pytest-dev/pytest/blob/master/_pytest/mark.py#L286 ) is used for two purposes:

  • store MarkInfo (args and kwargs) of one object
  • iterable collection of MarkInfo objects (list of args and kwargs)

This unclear usage leads to nasty bugs like #751 and makes requests like #759 too hard to implement. MarkInfo should be refactored into two classes one for each purpose.

@chmeldax
Copy link

@JanBednarik Well, did you start working on it or what is the progress of this "enhacement"? I just wonder if I should somehow reopen #759 :)

@JanBednarik
Copy link
Contributor Author

@chmeldax I started working on it, but looks like deeper issue.

@RonnyPfannschmidt Should I work on this? Or you will deal with this in issue #891 ?

@RonnyPfannschmidt
Copy link
Member

@JanBednarik for easing #891 some toolings to delcare/use and merge collections of marks seem handy - more communication needed, are you by chance on irc, or is another medium better

@RonnyPfannschmidt RonnyPfannschmidt added the topic: marks related to marks, either the general marks or builtin label May 14, 2017
@RonnyPfannschmidt
Copy link
Member

the underlying refactorings are done, the other facade will get a new api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: marks related to marks, either the general marks or builtin
Projects
None yet
Development

No branches or pull requests

3 participants