junitxml parses report.nodeid incorrectly

[pytestbot]

Originally reported by: Andrei Baidarov (BitBucket: tIGO, GitHub: tIGO)

---

If test param contains '::' junitxml parses report.nodeid incorrectly. For example, for test

#!python

import pytest

@pytest.mark.parametrize('foo', ['1::2'])
def testA(foo):
    assert True

py.test --junitxml=1 test.py produces xml with classname="test.testA[1" and name="2]" instead of classname="test" and name="testA[1::2]".

---

• Bitbucket: https://bitbucket.org/pytest-dev/pytest/issue/469

[RonnyPfannschmidt]

Due to implementation details this s one is flaky to fix

[tomviner]

Could you take a look at this @RonnyPfannschmidt
master...tomviner:issue469-junit-double-colon

If it's a reasonable start, I'll create a PR, so we can discuss the detail line by line as required.

[RonnyPfannschmidt]

I would propose to move all logic to the mangle-names function, and directly passing it the nodeid

[tomviner]

Yes that's a very reasonable point. PR #1431