pytest triggering deprecation warnings in 3.0.5

[nicoddemus]

As commented by @nedbat in https://bitbucket.org/ned/coveragepy/pull-requests/94, it seems pytest itself is making use of the deprecated compatproperty names:

/Users/ned/coverage/trunk/.tox/py27/lib/python2.7/site-packages/_pytest/fixtures.py:1071: PendingDeprecationWarning: This usage is deprecated, please use pytest.Class instead
  obj = getattr(holderobj, name, None)
/Users/ned/coverage/trunk/.tox/py27/lib/python2.7/site-packages/_pytest/fixtures.py:1071: PendingDeprecationWarning: This usage is deprecated, please use pytest.File instead
  obj = getattr(holderobj, name, None)
/Users/ned/coverage/trunk/.tox/py27/lib/python2.7/site-packages/_pytest/fixtures.py:1071: PendingDeprecationWarning: This usage is deprecated, please use pytest.Function instead
  obj = getattr(holderobj, name, None)
/Users/ned/coverage/trunk/.tox/py27/lib/python2.7/site-packages/_pytest/fixtures.py:1071: PendingDeprecationWarning: This usage is deprecated, please use pytest.Instance instead
  obj = getattr(holderobj, name, None)
/Users/ned/coverage/trunk/.tox/py27/lib/python2.7/site-packages/_pytest/fixtures.py:1071: PendingDeprecationWarning: This usage is deprecated, please use pytest.Item instead
  obj = getattr(holderobj, name, None)
/Users/ned/coverage/trunk/.tox/py27/lib/python2.7/site-packages/_pytest/fixtures.py:1071: PendingDeprecationWarning: This usage is deprecated, please use pytest.Module instead
  obj = getattr(holderobj, name, None)

cc @nmundar

[RonnyPfannschmidt]

this may prove tricky, it happens in parse_factories

[nedbat]

Couldn't you put a "with warnings.catch_warnings():" around line 1071? https://docs.python.org/3/library/warnings.html#temporarily-suppressing-warnings

[RonnyPfannschmidt]

i'd rather investigate why we run into those objects, and whether we can avoid the situation to begin with (as we could be hiding other deprecations as well)

[nedbat]

A quick test in my tox virtualenv seems to show that the context manager doesn't prevent the warnings..?

BTW, I run my test suite with:

# We want to see all warnings while we are running tests.  But we also need to
# disable warnings for some of the more complex setting up of tests.
warnings.simplefilter("default")

# Silence specific warnings that are not our fault.
warnings.filterwarnings("ignore", module="xdist", message="type argument to addoption")

So I try to see warnings, but that last line is to suppress a warning that pytest-xdist causes.

[nedbat]

Oops, I hadn't tried catch_warnings correctly. This works, and should only silence this specific warning:

with warnings.catch_warnings():
    warnings.filterwarnings("ignore", message="This usage is deprecated, please use pytest.* instead")
    obj = getattr(holderobj, name, None)

[RonnyPfannschmidt]

@nedbat if i recall correctly that operation will reset the once filter cache of the warnings module in various python version

[RonnyPfannschmidt]

@nedbat the real bug is, that it tries to operate on a Node object as test object

[RonnyPfannschmidt]

@nicoddemus @nedbat the problem lies in _pytest/python.py:360 - getcustomclass triggers this

i will fix this one

[The-Compiler]

I can confirm this, breaks my testsuite since I use -Werror 😉

Bisected to b38fad4 - cc @nmundar

[nicoddemus]

After @RonnyPfannschmidt fixes it, should we do a 3.0.6 release or it can wait a few weeks?

[RonnyPfannschmidt]

@The-Compiler you should never error on pending ones tho ^^