-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 fails with importorskip on module level #1822
Labels
type: regression
indicates a problem that was introduced in a release which was working previously
Comments
The-Compiler
added
the
type: regression
indicates a problem that was introduced in a release which was working previously
label
Aug 19, 2016
Probably what's happening is that |
@The-Compiler went with your suggestion, going to open a PR in a few minutes. |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this issue
Aug 19, 2016
This was referenced Aug 24, 2016
This was referenced Feb 4, 2018
This was referenced Feb 12, 2018
This was referenced Feb 20, 2018
This was referenced Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: regression
indicates a problem that was introduced in a release which was working previously
Because 3.0 disallows
pytest.skip
at module-level, usingpytest.importorskip
fails:with 2.9.2:
with 3.0.0:
This was pointed out in
#pylib
by @jaraco as setuptools did run into it: test_msvc.pyI think this is a valid pattern (and the error message is confusing) - maybe
pytest.skip
should have someallow_module_level
argument andimportorskip
should use it (without me actually having looked at the code)?cc @omarkohl
The text was updated successfully, but these errors were encountered: