Skip to content

deselection incorrectly determines the deselection reason #1372

Closed
@RonnyPfannschmidt

Description

@RonnyPfannschmidt

the combination of the terminal plugin and the mark plugin assume, only the mark plugin can deselect tests

so that's whats being used in the terminal summary, and the hook for Deselection does not consider getting a deselection Reason

i propose adding a deselection reason too the hook and requiring plugins that deselect to pass it
starting in 3.0

in order to support that we might need to add support for defaults to hook invocation and specification in pluggy

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogtype: enhancementnew feature or API change, should be merged into features branchtype: feature-branchnew feature or API change, should be merged into features branchtype: refactoringinternal improvements to the code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions