Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest 8.0.0 --maxfail fix caused a regression in pytest-xdist #12021

Closed
bluetech opened this issue Feb 23, 2024 · 0 comments · Fixed by #12022
Closed

Pytest 8.0.0 --maxfail fix caused a regression in pytest-xdist #12021

bluetech opened this issue Feb 23, 2024 · 0 comments · Fixed by #12022
Assignees
@bluetech
Labels
type: bug problem that needs to be addressed type: regression indicates a problem that was introduced in a release which was working previously

Comments

@bluetech
Copy link
Member

See pytest-dev/pytest-xdist#1024. When using --maxfail and the max fails is reached in a certain worker, the worker executes session fixture teardown twice. A fix in pytest-xdist is not very simple from what I can tell.
@bluetech bluetech added type: bug problem that needs to be addressed type: regression indicates a problem that was introduced in a release which was working previously labels Feb 23, 2024
@bluetech bluetech self-assigned this Feb 23, 2024
bluetech added a commit to bluetech/pytest that referenced this issue Feb 23, 2024
@bluetech
Revert "Fix teardown error reporting when --maxfail=1 (pytest-dev#1…
00d9640 
…1721)"

Fix pytest-dev#12021.
Reopens pytest-dev#11706.

This reverts commit 12b9bd5.

This change caused a bad regression in pytest-xdist:
pytest-dev/pytest-xdist#1024

pytest-xdist necessarily has special handling of `--maxfail` and session
fixture teardown get executed multiple times with the change.

Since I'm not sure how to adapt pytest-xdist myself, revert for now.

I kept the sticky `shouldstop`/`shouldfail` changes as they are good
ideas regardless I think.
@bluetech bluetech mentioned this issue Feb 23, 2024
Merged
flying-sheep pushed a commit to flying-sheep/pytest that referenced this issue Apr 9, 2024
@bluetech @flying-sheep
Revert "Fix teardown error reporting when --maxfail=1 (pytest-dev#1…
4cc87ad 
…1721)"

Fix pytest-dev#12021.
Reopens pytest-dev#11706.

This reverts commit 12b9bd5.

This change caused a bad regression in pytest-xdist:
pytest-dev/pytest-xdist#1024

pytest-xdist necessarily has special handling of `--maxfail` and session
fixture teardown get executed multiple times with the change.

Since I'm not sure how to adapt pytest-xdist myself, revert for now.

I kept the sticky `shouldstop`/`shouldfail` changes as they are good
ideas regardless I think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bluetech bluetech

Labels
type: bug problem that needs to be addressed type: regression indicates a problem that was introduced in a release which was working previously
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix teardown error reporting when --maxfail=1 (#11721)" bluetech/pytest
1 participant
@bluetech