Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set sys.last_exc in addition to last_type/last_value/last_traceback on Python>=3.12 #11850

Closed
bluetech opened this issue Jan 21, 2024 · 1 comment · Fixed by #12027
Closed

Set sys.last_exc in addition to last_type/last_value/last_traceback on Python>=3.12 #11850

bluetech opened this issue Jan 21, 2024 · 1 comment · Fixed by #12027
Labels
type: enhancement new feature or API change, should be merged into features branch

Comments

@bluetech
Copy link
Member

Python 3.12 added sys.last_exc. We should set it like we do the older variants.
@bluetech bluetech added the type: enhancement new feature or API change, should be merged into features branch label Jan 21, 2024
@robotherapist robotherapist mentioned this issue Feb 5, 2024
Closed
@robotherapist
Copy link
Contributor

Hey @bluetech, I submitted a PR: #11934

As last_exc is the same as last_value (from trying locally and looking at python here), and have added an if to check we're only using it on Python versions >= 3.12.0. Let me know if I need to do anything else!

bluetech pushed a commit to bluetech/pytest that referenced this issue Feb 23, 2024
@robotherapist @bluetech
runner: add support for sys.last_exc for post-mortem debugging on P…
c09f746 
…ython>=3.12

Fix pytest-dev#11850
@bluetech bluetech mentioned this issue Feb 23, 2024
Merged
flying-sheep pushed a commit to flying-sheep/pytest that referenced this issue Apr 9, 2024
@robotherapist @flying-sheep
runner: add support for sys.last_exc for post-mortem debugging on P…
a5a737f 
…ython>=3.12

Fix pytest-dev#11850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Milestone
No milestone
2 participants
@bluetech @robotherapist