Skip to content

Commit d4872f5

Browse files
committed
fixtures: tiny code cleanup
1 parent 8d815ca commit d4872f5

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/_pytest/fixtures.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,16 +210,14 @@ def reorder_items(items: Sequence[nodes.Item]) -> List[nodes.Item]:
210210
argkeys_cache: Dict[Scope, Dict[nodes.Item, Dict[FixtureArgKey, None]]] = {}
211211
items_by_argkey: Dict[Scope, Dict[FixtureArgKey, Deque[nodes.Item]]] = {}
212212
for scope in HIGH_SCOPES:
213-
d: Dict[nodes.Item, Dict[FixtureArgKey, None]] = {}
214-
argkeys_cache[scope] = d
215-
item_d: Dict[FixtureArgKey, Deque[nodes.Item]] = defaultdict(deque)
216-
items_by_argkey[scope] = item_d
213+
scoped_argkeys_cache = argkeys_cache[scope] = {}
214+
scoped_items_by_argkey = items_by_argkey[scope] = defaultdict(deque)
217215
for item in items:
218216
keys = dict.fromkeys(get_parametrized_fixture_keys(item, scope), None)
219217
if keys:
220-
d[item] = keys
218+
scoped_argkeys_cache[item] = keys
221219
for key in keys:
222-
item_d[key].append(item)
220+
scoped_items_by_argkey[key].append(item)
223221
items_dict = dict.fromkeys(items, None)
224222
return list(
225223
reorder_items_atscope(items_dict, argkeys_cache, items_by_argkey, Scope.Session)

0 commit comments

Comments
 (0)