Skip symlink sibling test on Windows without symlink support #13771

Author: Mulat Mekonen

AUTHORS

@@ -320,6 +320,7 @@ Mike Hoyle (hoylemd)
 Mike Lundy
 Milan Lesnek
 Miro Hrončok
+Mulat Mekonen
 mrbean-bremen
 Nathan Goldbaum
 Nathan Rousseau

changelog/12039.contrib.rst

@@ -0,0 +1 @@
+Skip `test_do_not_collect_symlink_siblings` on Windows environments without symlink support to avoid false negatives.

changelog/13771.bugfix.rst

@@ -0,0 +1 @@
+Skip `test_do_not_collect_symlink_siblings` on Windows environments without symlink support to avoid false negatives.

testing/test_collection.py

@@ -1864,14 +1864,16 @@ def test_do_not_collect_symlink_siblings(
     pytester: Pytester, tmp_path: Path, request: pytest.FixtureRequest
 ) -> None:
     """
-    Regression test for #12039: Do not collect from directories that are symlinks to other directories in the same path.
+    Regression test for #12039: Do not collect from directories that are symlinks
+    to other directories in the same path.
 
-    The check for short paths under Windows via os.path.samefile, introduced in #11936, also finds the symlinked
-    directory created by tmp_path/tmpdir.
+    On Windows without Developer Mode or admin rights, symlink creation may fail.
+    In that case we skip this test to avoid false negatives.
     """
     # Use tmp_path because it creates a symlink with the name "current" next to the directory it creates.
     symlink_path = tmp_path.parent / (tmp_path.name[:-1] + "current")
-    assert symlink_path.is_symlink() is True
+    if not symlink_path.is_symlink():
+        pytest.skip("Symlinks not supported in this environment")
 
     # Create test file.
     tmp_path.joinpath("test_foo.py").write_text("def test(): pass", encoding="UTF-8")