Skip to content

Fix test_warning_captured_deprecated_in_pytest_6 #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

nicoddemus
Copy link
Member

This test started to fail in the 'py38-pytestmain' environment, the cause being PytestRemovedIn7Warning being raised by the conftest.py file of the test itself. Ignoring it is fine, the purpose of the test is to ensure the hook is not called by pytest-xdist.

This test started to fail in the 'py38-pytestmain' environment, the
cause being PytestRemovedIn7Warning being raised by the conftest file
of the test itself. Ignoring it is fine, the purpose of the test is to ensure
the hook is not called by pytest-xdist.
@nicoddemus nicoddemus requested a review from bluetech November 28, 2021 13:35
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the test will keep working even in pytest 7.1. So LGTM.

@nicoddemus nicoddemus merged commit 408eb1c into pytest-dev:master Nov 28, 2021
@nicoddemus nicoddemus deleted the fix-warning-captured-test branch November 28, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants