qtlog returns empty message lists with --qt-no-log option

Author: nicoddemus

pytestqt/_tests/test_logging.py

@@ -62,5 +62,26 @@ def test_qtlog_fixture(qtlog):
         (QtWarningMsg, 'this is a WARNING message '),
         (QtCriticalMsg, 'this is a CRITICAL message '),
     ]
+    # `messages` attribute is read-only
     with pytest.raises(AttributeError):
-        qtlog.messages = []
+        qtlog.messages = []
+
+
+def test_fixture_with_loggin_disabled(testdir):
+    """
+    Test that qtlog fixture doesn't capture anything if logging is disabled
+    in the command line.
+
+    :type testdir: _pytest.pytester.TmpTestdir
+    """
+    testdir.makepyfile(
+        """
+        from pytestqt.qt_compat import qWarning
+
+        def test_types(qtlog):
+            qWarning('message')
+            assert qtlog.messages == []
+        """
+    )
+    res = testdir.runpytest('--no-qt-log')
+    res.stdout.fnmatch_lines('*1 passed*')

pytestqt/plugin.py

@@ -517,4 +517,7 @@ def get_msg_name(cls, msg_type):
 @pytest.fixture
 def qtlog(request):
     """Fixture that can access messages captured during testing"""
-    return request._pyfuncitem.qt_log_capture
+    if hasattr(request._pyfuncitem, 'qt_log_capture'):
+        return request._pyfuncitem.qt_log_capture
+    else:
+        return _QtMessageCapture()