Skip to content

Commit bd683cc

Browse files
committed
Refactoring: add Item class
- caches some often used properties - fix performance tests for relative sorting - add some small optimizations
1 parent 36b1437 commit bd683cc

File tree

2 files changed

+245
-202
lines changed

2 files changed

+245
-202
lines changed

perf_tests/test_order.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,20 @@ def fixture_path_relative(tmpdir_factory):
3636
test_contents = """
3737
import pytest
3838
"""
39-
for i in range(100):
39+
for i in range(90):
4040
test_contents += """
4141
@pytest.mark.order(after="test_{}")
4242
def test_{}():
4343
assert True
44-
""".format(i + 10 % 100, i)
44+
""".format(i + 10, i)
45+
for i in range(10):
46+
test_contents += """
47+
def test_{}():
48+
assert True
49+
""".format(i + 90)
4550
write_test(testname, test_contents)
4651
yield fixture_path
47-
shutil.rmtree(fixture_path, ignore_errors=True)
52+
# shutil.rmtree(fixture_path, ignore_errors=True)
4853

4954

5055
@pytest.fixture
@@ -91,4 +96,4 @@ def test_performance_relative(self, fixture_path_relative):
9196
pytest.main(args, [pytest_order])
9297
overhead_time = time.time() - start_time - self.__class__.base_time
9398
print("Overhead per test: {:.3f} ms".format(overhead_time))
94-
assert overhead_time < 0.8
99+
assert overhead_time < 1.5

0 commit comments

Comments
 (0)