Skip to content

Commit 57ad1cb

Browse files
committed
Merge branch 'master' into 44-duplicated-traceback
2 parents 49481aa + 74f9740 commit 57ad1cb

File tree

6 files changed

+49
-186
lines changed

6 files changed

+49
-186
lines changed

CHANGELOG.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
1.1
22
---
33

4+
* From this version onward, ``pytest-mock`` is licensed under the `MIT`_ license (`#45`_).
5+
46
* Now the plugin also adds introspection information on differing call arguments when
57
calling helper methods such as ``assert_called_once_with``. The extra introspection
68
information is similar to pytest's and can be disabled with the ``mock_traceback_monkeypatch``
@@ -20,11 +22,19 @@
2022
anyway plus it generates confusing messages on Python 3.5 due to exception chaining (`#44`_).
2123
Thanks `@blueyed`_ for the report.
2224

25+
* ``mock.call`` is now aliased as ``mocker.call`` for convenience.
26+
Thanks `@jhermann`_ for the PR (`#49`_).
27+
2328
.. _@jurko-gospodnetic: https://github.com/jurko-gospodnetic
2429
.. _@asfaltboy: https://github.com/asfaltboy
30+
.. _@jhermann: https://github.com/jhermann
31+
.. _#45: https://github.com/pytest-dev/pytest-mock/issues/45
2532
.. _#36: https://github.com/pytest-dev/pytest-mock/issues/36
2633
.. _#40: https://github.com/pytest-dev/pytest-mock/issues/40
2734
.. _#44: https://github.com/pytest-dev/pytest-mock/issues/44
35+
.. _#49: https://github.com/pytest-dev/pytest-mock/issues/49
36+
.. _MIT: https://github.com/pytest-dev/pytest-mock/blob/master/LICENSE
37+
2838

2939
1.0
3040
---

LICENSE

Lines changed: 21 additions & 165 deletions
Original file line numberDiff line numberDiff line change
@@ -1,165 +1,21 @@
1-
GNU LESSER GENERAL PUBLIC LICENSE
2-
Version 3, 29 June 2007
3-
4-
Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
5-
Everyone is permitted to copy and distribute verbatim copies
6-
of this license document, but changing it is not allowed.
7-
8-
9-
This version of the GNU Lesser General Public License incorporates
10-
the terms and conditions of version 3 of the GNU General Public
11-
License, supplemented by the additional permissions listed below.
12-
13-
0. Additional Definitions.
14-
15-
As used herein, "this License" refers to version 3 of the GNU Lesser
16-
General Public License, and the "GNU GPL" refers to version 3 of the GNU
17-
General Public License.
18-
19-
"The Library" refers to a covered work governed by this License,
20-
other than an Application or a Combined Work as defined below.
21-
22-
An "Application" is any work that makes use of an interface provided
23-
by the Library, but which is not otherwise based on the Library.
24-
Defining a subclass of a class defined by the Library is deemed a mode
25-
of using an interface provided by the Library.
26-
27-
A "Combined Work" is a work produced by combining or linking an
28-
Application with the Library. The particular version of the Library
29-
with which the Combined Work was made is also called the "Linked
30-
Version".
31-
32-
The "Minimal Corresponding Source" for a Combined Work means the
33-
Corresponding Source for the Combined Work, excluding any source code
34-
for portions of the Combined Work that, considered in isolation, are
35-
based on the Application, and not on the Linked Version.
36-
37-
The "Corresponding Application Code" for a Combined Work means the
38-
object code and/or source code for the Application, including any data
39-
and utility programs needed for reproducing the Combined Work from the
40-
Application, but excluding the System Libraries of the Combined Work.
41-
42-
1. Exception to Section 3 of the GNU GPL.
43-
44-
You may convey a covered work under sections 3 and 4 of this License
45-
without being bound by section 3 of the GNU GPL.
46-
47-
2. Conveying Modified Versions.
48-
49-
If you modify a copy of the Library, and, in your modifications, a
50-
facility refers to a function or data to be supplied by an Application
51-
that uses the facility (other than as an argument passed when the
52-
facility is invoked), then you may convey a copy of the modified
53-
version:
54-
55-
a) under this License, provided that you make a good faith effort to
56-
ensure that, in the event an Application does not supply the
57-
function or data, the facility still operates, and performs
58-
whatever part of its purpose remains meaningful, or
59-
60-
b) under the GNU GPL, with none of the additional permissions of
61-
this License applicable to that copy.
62-
63-
3. Object Code Incorporating Material from Library Header Files.
64-
65-
The object code form of an Application may incorporate material from
66-
a header file that is part of the Library. You may convey such object
67-
code under terms of your choice, provided that, if the incorporated
68-
material is not limited to numerical parameters, data structure
69-
layouts and accessors, or small macros, inline functions and templates
70-
(ten or fewer lines in length), you do both of the following:
71-
72-
a) Give prominent notice with each copy of the object code that the
73-
Library is used in it and that the Library and its use are
74-
covered by this License.
75-
76-
b) Accompany the object code with a copy of the GNU GPL and this license
77-
document.
78-
79-
4. Combined Works.
80-
81-
You may convey a Combined Work under terms of your choice that,
82-
taken together, effectively do not restrict modification of the
83-
portions of the Library contained in the Combined Work and reverse
84-
engineering for debugging such modifications, if you also do each of
85-
the following:
86-
87-
a) Give prominent notice with each copy of the Combined Work that
88-
the Library is used in it and that the Library and its use are
89-
covered by this License.
90-
91-
b) Accompany the Combined Work with a copy of the GNU GPL and this license
92-
document.
93-
94-
c) For a Combined Work that displays copyright notices during
95-
execution, include the copyright notice for the Library among
96-
these notices, as well as a reference directing the user to the
97-
copies of the GNU GPL and this license document.
98-
99-
d) Do one of the following:
100-
101-
0) Convey the Minimal Corresponding Source under the terms of this
102-
License, and the Corresponding Application Code in a form
103-
suitable for, and under terms that permit, the user to
104-
recombine or relink the Application with a modified version of
105-
the Linked Version to produce a modified Combined Work, in the
106-
manner specified by section 6 of the GNU GPL for conveying
107-
Corresponding Source.
108-
109-
1) Use a suitable shared library mechanism for linking with the
110-
Library. A suitable mechanism is one that (a) uses at run time
111-
a copy of the Library already present on the user's computer
112-
system, and (b) will operate properly with a modified version
113-
of the Library that is interface-compatible with the Linked
114-
Version.
115-
116-
e) Provide Installation Information, but only if you would otherwise
117-
be required to provide such information under section 6 of the
118-
GNU GPL, and only to the extent that such information is
119-
necessary to install and execute a modified version of the
120-
Combined Work produced by recombining or relinking the
121-
Application with a modified version of the Linked Version. (If
122-
you use option 4d0, the Installation Information must accompany
123-
the Minimal Corresponding Source and Corresponding Application
124-
Code. If you use option 4d1, you must provide the Installation
125-
Information in the manner specified by section 6 of the GNU GPL
126-
for conveying Corresponding Source.)
127-
128-
5. Combined Libraries.
129-
130-
You may place library facilities that are a work based on the
131-
Library side by side in a single library together with other library
132-
facilities that are not Applications and are not covered by this
133-
License, and convey such a combined library under terms of your
134-
choice, if you do both of the following:
135-
136-
a) Accompany the combined library with a copy of the same work based
137-
on the Library, uncombined with any other library facilities,
138-
conveyed under the terms of this License.
139-
140-
b) Give prominent notice with the combined library that part of it
141-
is a work based on the Library, and explaining where to find the
142-
accompanying uncombined form of the same work.
143-
144-
6. Revised Versions of the GNU Lesser General Public License.
145-
146-
The Free Software Foundation may publish revised and/or new versions
147-
of the GNU Lesser General Public License from time to time. Such new
148-
versions will be similar in spirit to the present version, but may
149-
differ in detail to address new problems or concerns.
150-
151-
Each version is given a distinguishing version number. If the
152-
Library as you received it specifies that a certain numbered version
153-
of the GNU Lesser General Public License "or any later version"
154-
applies to it, you have the option of following the terms and
155-
conditions either of that published version or of any later version
156-
published by the Free Software Foundation. If the Library as you
157-
received it does not specify a version number of the GNU Lesser
158-
General Public License, you may choose any version of the GNU Lesser
159-
General Public License ever published by the Free Software Foundation.
160-
161-
If the Library as you received it specifies that a proxy can decide
162-
whether future versions of the GNU Lesser General Public License shall
163-
apply, that proxy's public statement of acceptance of any version is
164-
permanent authorization for you to choose that version for the
165-
Library.
1+
MIT License
2+
3+
Copyright (c) [2016] [Bruno Oliveira]
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy
6+
of this software and associated documentation files (the "Software"), to deal
7+
in the Software without restriction, including without limitation the rights
8+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9+
copies of the Software, and to permit persons to whom the Software is
10+
furnished to do so, subject to the following conditions:
11+
12+
The above copyright notice and this permission notice shall be included in all
13+
copies or substantial portions of the Software.
14+
15+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21+
SOFTWARE.

README.rst

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,13 @@ The supported methods are:
6262
* ``mocker.stopall()``: stops all active patches up to this point.
6363
* ``mocker.resetall()``: calls ``reset_mock()`` in all mocked objects up to this point.
6464

65-
Some objects from the ``mock`` module are accessible directly from ``mocker`` so
66-
you don't have to import it:
65+
Some objects from the ``mock`` module are accessible directly from ``mocker`` for convenience:
6766

6867
* `Mock <https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock>`_
6968
* `MagicMock <https://docs.python.org/3/library/unittest.mock.html#unittest.mock.MagicMock>`_
7069
* `PropertyMock <https://docs.python.org/3/library/unittest.mock.html#unittest.mock.PropertyMock>`_
70+
* `ANY <https://docs.python.org/3/library/unittest.mock.html#any>`_
71+
* `call <https://docs.python.org/3/library/unittest.mock.html#call>`_ *(Version 1.1)*
7172

7273

7374
Spy
@@ -247,3 +248,11 @@ Although mocker's API is intentionally the same as ``mock.patch``'s, its uses as
247248
in test_context_manager
248249
with mocker.patch.object(a, 'doIt', return_value=True, autospec=True):
249250
E AttributeError: __exit__
251+
252+
253+
License
254+
=======
255+
256+
Distributed under the terms of the `MIT`_ license.
257+
258+
.. _MIT: https://github.com/pytest-dev/pytest-mock/blob/master/LICENSE

pytest_mock.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class MockFixture(object):
2020
Mock = mock_module.Mock
2121
MagicMock = mock_module.MagicMock
2222
PropertyMock = mock_module.PropertyMock
23+
call = mock_module.call
2324
ANY = mock_module.ANY
2425

2526
def __init__(self):

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,17 @@
2222
':python_version=="2.6" or python_version=="2.7"': ['mock'],
2323
},
2424
url='https://github.com/pytest-dev/pytest-mock/',
25-
license='LGPL',
25+
license='MIT',
2626
author='Bruno Oliveira',
2727
author_email='nicoddemus@gmail.com',
2828
description='Thin-wrapper around the mock package for easier use with py.test',
2929
long_description=open('README.rst').read(),
3030
keywords="pytest mock",
3131
classifiers=[
32-
'Development Status :: 4 - Beta',
32+
'Development Status :: 5 - Production/Stable',
3333
'Framework :: Pytest',
3434
'Intended Audience :: Developers',
35-
'License :: OSI Approved :: GNU Lesser General Public License v3 (LGPLv3)',
35+
'License :: OSI Approved :: MIT License',
3636
'Operating System :: OS Independent',
3737
'Programming Language :: Python :: 2.6',
3838
'Programming Language :: Python :: 2.7',

test_pytest_mock.py

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -132,25 +132,12 @@ def test_deprecated_mock(mock, tmpdir):
132132
assert os.listdir(str(tmpdir)) == []
133133

134134

135-
def test_mocker_has_magic_mock_class_as_attribute_for_instantiation():
135+
@pytest.mark.parametrize('name', ['MagicMock', 'PropertyMock', 'Mock', 'call', 'ANY'])
136+
def test_mocker_aliases(name):
136137
from pytest_mock import mock_module, MockFixture
137138

138139
mocker = MockFixture()
139-
assert isinstance(mocker.MagicMock(), mock_module.MagicMock)
140-
141-
142-
def test_mocker_has_property_mock_class_as_attribute_for_instantiation():
143-
from pytest_mock import mock_module, MockFixture
144-
145-
mocker = MockFixture()
146-
assert isinstance(mocker.PropertyMock(), mock_module.PropertyMock)
147-
148-
149-
def test_mocker_has_mock_class_as_attribute_for_instantiation():
150-
from pytest_mock import mock_module, MockFixture
151-
152-
mocker = MockFixture()
153-
assert isinstance(mocker.Mock(), mock_module.Mock)
140+
assert getattr(mocker, name) is getattr(mock_module, name)
154141

155142

156143
def test_mocker_resetall(mocker):

0 commit comments

Comments
 (0)