Repository navigation
Control render using configuration - #267
Conversation
|
@BeyondEvil As agreed in #239 I gave this a shot. The render is must faster now but unfortunately the collapsed class is misplaced. This means it is no longer possible to unfold the details/extras. With this PR, setting <tr>
<td class="extra collapsed" colspan="4">
<div>but it should be <tr class="collapsed">
<td class="extra" colspan="4">
<div>By changing the implementation to the following it works for me if len(cells) > 0:
tr_class = None
if self.config.getini("render_collapsed"):
tr_class = "collapsed"
self.row_table = html.tr(cells)
self.row_extra = html.tr(
html.td(self.additional_html, class_="extra", colspan=len(cells)), class_=tr_class
)Essentially just moving the collapsed class to the parent |
lol, awkward. Good catch! In the end it was good, because I noticed JS needed an update as well to display the correct CSS. |
|
Released in v2.1.0 |
Fixes: #239