Improve detection of multiple event loops being requested in a test #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 2 2
Lines 480 480
Branches 96 96
=======================================
Hits 442 442
Misses 23 23
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
Blocked by #706 |
5 tasks
…ped loop is pulled in by an async autouse fixture in addition to an event loop with larger scope. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
… of a test item. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
async-autouse-fixture-triggers-multiple-loop-error
branch
from
bf6f5a7
to
bae1d1e
Compare
…e test. Previously, the detection was limited to a function-scoped loop and a higher-scoped loop. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
async-autouse-fixture-triggers-multiple-loop-error
branch
from
f492fd8
to
a70577c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #868