Test for, and suppress, additional get_event_loop() DeprecationWarnings #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
requested review from
asvetlov,
seifertm and
Tinche
as code owners
SyntaxColoring
commented
Apr 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 2 2
Lines 477 477
Branches 96 95 -1
=======================================
Hits 456 456
Misses 12 12
Partials 9 9 ☔ View full report in Codecov by Sentry. |
SyntaxColoring
commented
Apr 18, 2024
I don't think this matters, but maybe...
seifertm
requested changes
Apr 19, 2024
We can only reproduce this on specific Python 3.10.x patch versions, but we can't easily test those in CI. Give up the attempt.
|
@seifertm Ping—do the latest changes address your feedback? |
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to do what's described in #757 (comment), to solve continued instances of issue #757:
Add tests to catch any lingeringasyncio.get_event_loop()DeprecationWarnings.The existing tests are already catching a bunch, but only when they're run under specific Python patch versions. So the test part of this PR just configures tox and GitHub Actions to do that.