Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve speed/efficiency of dataframe_from_inp function #92

Open
aerispaha opened this issue May 11, 2020 · 0 comments
Open

improve speed/efficiency of dataframe_from_inp function #92

aerispaha opened this issue May 11, 2020 · 0 comments

Comments

@aerispaha
Copy link
Member

aerispaha commented May 11, 2020

Currently, the dataframe_from_inp (and similar functions) scan the text file twice to extract the content. First, by running the get_inp_sections_details function, then by scanning to the section of interest.

It might be possible to avoid the first scan through the of text file by using a pre-populated list of end_strings in the extract_section_of_file function call, thereby possibly removing the need to run get_inp_sections_details. This would be useful when dealing with large files and/or over a network.

@aerispaha aerispaha added this to the v0.5.0 milestone May 11, 2020
@aerispaha aerispaha changed the title improve speed of dataframe_from_inp improve speed/efficiency of dataframe_from_inp function May 11, 2020
@aerispaha aerispaha removed this from the v0.5.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant