Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'delim_whitespace' will be depreciated #221

Open
bowguy opened this issue Aug 6, 2024 · 5 comments
Open

'delim_whitespace' will be depreciated #221

bowguy opened this issue Aug 6, 2024 · 5 comments

Comments

@bowguy
Copy link
Contributor

bowguy commented Aug 6, 2024

Getting a warning:
FutureWarning: The 'delim_whitespace' keyword in pd.read_csv is deprecated and will be removed in a future version. Use sep='\s+' instead

Change needed in
swmmio\utils\dataframes.py:107
swmmio\utils\dataframes.py:167
swmmio\utils\text.py:265
@bemcdonnell
Copy link
Member

@bowguy, can you submit a pull request to fix this?

@bowguy
Copy link
Contributor Author

bowguy commented Aug 6, 2024

Sure. I think I did one of those once...

@bowguy
Copy link
Contributor Author

bowguy commented Aug 7, 2024

Pull request creation failed. Validation failed: must be a collaborator ??

@bemcdonnell
Copy link
Member

@bowguy Fork the project into your github account and push your changes there. Then submit a PR from your fork

@bowguy
Copy link
Contributor Author

bowguy commented Aug 7, 2024

Done

@rpachaly rpachaly mentioned this issue Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bowguy @bemcdonnell