Move project_type validation higher (#145)

Author: FabioRosado

src/pyscript/_generator.py

@@ -109,10 +109,17 @@ def create_project(
     if not pyscript_version:
         pyscript_version = _get_latest_pyscript_version()
 
+    if project_type == "app":
+        template = "basic.html"
+    else:
+        raise ValueError(
+            f"Unknown project type: {project_type}. Valid values are: 'app'"
+        )
+
     context = {
         "name": app_name,
         "description": app_description,
-        "type": "app",
+        "type": project_type,
         "author_name": author_name,
         "author_email": author_email,
         "version": "latest",
@@ -125,13 +132,6 @@ def create_project(
     save_config_file(manifest_file, context)
     output_path = app_dir / "index.html" if output is None else app_dir / output
 
-    if project_type == "app":
-        template = "basic.html"
-    else:
-        raise ValueError(
-            f"Unknown project type: {project_type}. Valid values are: 'app'"
-        )
-
     python_filepath = app_dir / "main.py"
 
     if not wrap:

tests/test_cli.py

@@ -72,6 +72,16 @@ def test_create_command(
     assert 'author_email = ""' in config_text
 
 
+def test_create_command_bad_app_type(
+    invoke_cli: CLIInvoker, tmp_path: Path, app_details_args: list[str], auto_enter
+) -> None:
+    result = invoke_cli("create", "myapp", "--project-type", "bad_type")
+    assert (
+        str(result.exception)
+        == "Unknown project type: bad_type. Valid values are: 'app'"
+    )
+
+
 def test_create_command_no_app_name(
     invoke_cli: CLIInvoker, tmp_path: Path, app_details_args: list[str], auto_enter
 ) -> None: