chore: increase worker startup timeout #14474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest Celery release 5.3.2, the default startup time of 4.0 seconds is no longer fast enough for some of our worker bootups. This is not a full solution, rather a stopgap to allow workers to thrash less. Fixes WAREHOUSE-PRODUCTION-1FX Fixes WAREHOUSE-PRODUCTION-1M4 Fixes WAREHOUSE-PRODUCTION-1M5 Fixes WAREHOUSE-STAGING-MK Fixes WAREHOUSE-STAGING-MM Fixes WAREHOUSE-STAGING-N8 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
ewdurbin
approved these changes
Sep 1, 2023
miketheman
added a commit
to miketheman/warehouse
that referenced
this pull request
Sep 1, 2023
This reverts commit a29912c.
ewdurbin
pushed a commit
that referenced
this pull request
Sep 3, 2023
* Revert "chore: increase worker startup timeout (#14474)" This reverts commit a29912c. * chore: revert celery and kombu upgrade We're seeing some slowdowns and startup time alerts with the latest versions. Signed-off-by: Mike Fiedler <miketheman@gmail.com> --------- Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest Celery release 5.3.2, the default startup time of 4.0 seconds is no longer fast enough for some of our worker bootups.
This is not a full solution, rather a stopgap to allow workers to thrash less.
Refs: https://python-software-foundation.sentry.io/share/issue/fc01ee336e3045199ea9918e41c0a05e/
Fixes WAREHOUSE-PRODUCTION-1FX
Fixes WAREHOUSE-PRODUCTION-1M4
Fixes WAREHOUSE-PRODUCTION-1M5
Fixes WAREHOUSE-STAGING-MK
Fixes WAREHOUSE-STAGING-MM
Fixes WAREHOUSE-STAGING-N8