Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple filter-panel/accordion into one component #6693

Open
woodruffw opened this issue Sep 23, 2019 · 0 comments
Open

Couple filter-panel/accordion into one component #6693

woodruffw opened this issue Sep 23, 2019 · 0 comments
Labels
CSS/SCSS requires change to CSS/SCSS files HTML requires change to HTML files

Comments

@woodruffw
Copy link
Member

woodruffw commented Sep 23, 2019 •
edited
Loading

#6665 currently assumes that the contents of a .filter-panel include a (potentially expanded) accordion for tabbing purposes. We should combine the .accordion and .filter-panel components into a single component to prevent confusion and potential future breakage.

cc @nlhkabu
@woodruffw woodruffw mentioned this issue Sep 23, 2019
Merged
@woodruffw woodruffw added CSS/SCSS requires change to CSS/SCSS files HTML requires change to HTML files labels Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS/SCSS requires change to CSS/SCSS files HTML requires change to HTML files
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@woodruffw