Detect if symlinks are supported on target file system #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This detects symlink suppot on destination filesystem and not only in Python interpreter or OS. If symlinks are not supported, falls back to copy behavior.
Detected by test failure https://travis-ci.org/pypa/virtualenv/jobs/131876888
home_dir didn't exists when symlink test started at https://travis-ci.org/pypa/virtualenv/jobs/152347070
|
@Ivoz @dstufft ready for review. People are patching utilities like tox with workarounds against this bug, and this PR should make it unnecessary - https://bitbucket.org/hpk42/tox/pull-requests/205/fix-issue-218/diff |
|
Ping? |
gaborbernat
force-pushed
the
master
branch
6 times, most recently
from
2b3f876
to
9dfcb43
Compare
gaborbernat
requested changes
Dec 16, 2018
|
Closing this due to inactivity. |
|
I couldn't wait 2 years. Sorry. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detects symlink suppot on destination filesystem and not only in Python interpreter or OS. If symlinks are not supported, falls back to copy behavior.
This fixes some case reported in #92 and #409, without specifying --always-copy explicitly.
Ideal case would be to invert virtualenv symlinking behavior - symlink only when explicitly requested.
This was migrated from #663 to reparent it to the
masterbranch. Please see original pull request for any previous discussion.