feat: added support for pkg-config
#2958
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, I modified the activation scripts for all supported shells. Now, when you activate a virtual environment, the `lib/pkgconfig` directory will be prepended to the `PKG_CONFIG_PATH` environment variable. The original value is restored upon deactivation. I also added unit tests for each shell to verify that the activation scripts are generated correctly and that `PKG_CONFIG_PATH` is set and unset as expected. Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
* Escapes the '&' character within the VIRTUAL_ENV_PROMPT variable in the batch activator. This prevents issues with batch scripts interpreting '&' as a command separator. * Removes an unnecessary '&' escaping from the test helper function `quote`, as the main logic now handles this correctly. Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
# Conflicts: # src/virtualenv/activation/via_template.py
for more information, see https://pre-commit.ci
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this, I modified the activation scripts for all supported shells. Now, when you activate a virtual environment, the
lib/pkgconfigdirectory will be prepended to thePKG_CONFIG_PATHenvironment variable. The original value is restored upon deactivation.I also added unit tests for each shell to verify that the activation scripts are generated correctly and that
PKG_CONFIG_PATHis set and unset as expected.tox -e fix)docs/changelogfolder