-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI: Add PyPy 3.11 to CI checks #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Includes PyPy 3.11 in the list of Python versions to test. * Excludes PyPy 3.11 on Windows 2025 to avoid potential compatibility issues. Closes pypa#2932 Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
* Simplify PyPy executable discovery logic. * Remove special handling for PyPy when sys.executable matches base_executable. * use base_executable directly when not in a virtual environment. Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
* Modify test to account for potential native executable differences. * The `_run_subprocess` call count can vary by 1 on macOS with Homebrew. * This change ensures the test correctly handles these variations. Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
9c0d60b to
bdf7d11
Compare
# Conflicts: # src/virtualenv/discovery/py_info.py
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
for more information, see https://pre-commit.ci
Why? We should really fix not exclude 🤔 |
gaborbernat
approved these changes
Aug 11, 2025
The test was failing, probably because pypy does not have |
We should at least open an issue to PyPy and link it to/from here. |
gaborbernat
pushed a commit
to gaborbernat/virtualenv
that referenced
this pull request
Oct 10, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


_fast_get_system_executable().test_py_info_cache_invalidation_on_py_info_change.Closes #2932
tox -e fix)docs/changelogfolder