Skip to content

Conversation

@esafak
Copy link
Contributor

@esafak esafak commented Aug 4, 2025

  • Includes PyPy 3.11 in the list of Python versions to test.
  • Excludes PyPy 3.11 on Windows 2025 to avoid potential compatibility issues.
  • Flattens _fast_get_system_executable().
  • Hardens test_py_info_cache_invalidation_on_py_info_change.

Closes #2932

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

esafak and others added 12 commits August 3, 2025 23:47
*   Includes PyPy 3.11 in the list of Python versions to test.
*   Excludes PyPy 3.11 on Windows 2025 to avoid potential compatibility issues.

Closes pypa#2932

Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
@esafak esafak closed this Aug 5, 2025
@esafak esafak deleted the feat/2932_pypy311 branch August 5, 2025 02:24
@esafak esafak restored the feat/2932_pypy311 branch August 5, 2025 02:29
@esafak esafak reopened this Aug 5, 2025
esafak added 2 commits August 4, 2025 23:33
* Simplify PyPy executable discovery logic.
* Remove special handling for PyPy when sys.executable matches base_executable.
* use base_executable directly when not in a virtual environment.

Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
* Modify test to account for potential native executable differences.
* The `_run_subprocess` call count can vary by 1 on macOS with Homebrew.
* This change ensures the test correctly handles these variations.

Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
@esafak esafak force-pushed the feat/2932_pypy311 branch from 9c0d60b to bdf7d11 Compare August 10, 2025 03:48
esafak and others added 6 commits August 9, 2025 23:53
# Conflicts:
#	src/virtualenv/discovery/py_info.py
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
@gaborbernat
Copy link
Contributor

  • Excludes PyPy 3.11 on Windows 2025 to avoid potential compatibility issues.

Why? We should really fix not exclude 🤔

@gaborbernat gaborbernat merged commit d280b76 into pypa:main Aug 11, 2025
45 checks passed
@esafak
Copy link
Contributor Author

esafak commented Aug 11, 2025

  • Excludes PyPy 3.11 on Windows 2025 to avoid potential compatibility issues.

Why? We should really fix not exclude 🤔

Screenshot 2025-08-11 at 10 19 05

The test was failing, probably because pypy does not have sys._base_executable. I could not investigate because pypy is not available on my system yet, so I disabled it.

@gaborbernat
Copy link
Contributor

  • Excludes PyPy 3.11 on Windows 2025 to avoid potential compatibility issues.

Why? We should really fix not exclude 🤔

Screenshot 2025-08-11 at 10 19 05 The test was failing, probably because pypy does not have `sys._base_executable`. I could not investigate because [pypy is not available on my system yet](https://github.com/macports/macports-ports/pull/29071), so I disabled it.

We should at least open an issue to PyPy and link it to/from here.

@esafak esafak deleted the feat/2932_pypy311 branch August 11, 2025 14:26
gaborbernat pushed a commit to gaborbernat/virtualenv that referenced this pull request Oct 10, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support / testing for PyPy 3.11

2 participants