Refactor/unify/extract shutil.rmtree
callbacks (and avoid repetition)
#4682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I noticed that there are at least 2 implementations of
shutil.rmtree
callbacks in setuptools: one foreasy_install
and one forbdist_wheel
. There is also other places in setuptools that we don't have those callbacks (so potentially still subject to errors on Windows?).So this PR tries to unify these 2 separated implementations.
I have chosen to extract the implementation from
easy_install
.One notable difference though is that
bdist_wheel
's implementation always try to apply thechmod
callback when it fails, while theeasy_install
implementation is more conservative and only applies the callback on Windows (similar to the suggestion inhttps://github.com/python/cpython/issues/87823#issuecomment-1093908280
)... So that might generate a bit of change in behaviour, but with a bit of luck should be compatible.The name
_shutil
was used for the lack of a better name/imagination, and can be changed.Closes
Pull Request Checklist
newsfragments/
.(See documentation for details)