Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ruff/pyupgrade rules (UP) #4379

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Enforce ruff/pyupgrade rules (UP) #4379

wants to merge 8 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

Summary of changes

Enforce ruff/pyupgrade rules (UP).

Follow-up of #4125.

Pull Request Checklist

@Avasam
Copy link
Contributor

Avasam commented May 22, 2024

You should ignore UP038 too ! astral-sh/ruff#7871

Avasam
Avasam reviewed May 22, 2024
View reviewed changes
ruff.toml Outdated Show resolved Hide resolved
@DimitriPapadopoulos DimitriPapadopoulos changed the title Enforce ruff/pyupgrade rules Enforce ruff/pyupgrade rules (UP) Jun 28, 2024
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review June 28, 2024 18:48
Avasam
Avasam reviewed Jun 29, 2024
View reviewed changes
Copy link
Contributor

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and imo potential non-automated improvements I noticed from also having applied UP03 in other projects

pkg_resources/__init__.py Show resolved Hide resolved
pkg_resources/__init__.py Show resolved Hide resolved
pkg_resources/tests/test_pkg_resources.py Show resolved Hide resolved
setuptools/command/easy_install.py Show resolved Hide resolved
setuptools/package_index.py Show resolved Hide resolved
setuptools/package_index.py Outdated Show resolved Hide resolved
setuptools/tests/config/test_setupcfg.py Outdated Show resolved Hide resolved
pkg_resources/__init__.py Show resolved Hide resolved
pkg_resources/__init__.py Outdated Show resolved Hide resolved
@DimitriPapadopoulos
Copy link
Contributor Author

Restarted from scratch, it's easier and less error-prone than rebasing.

@Avasam
Copy link
Contributor

Avasam commented Sep 18, 2024

Might wanna disable UP027 too (I've done so here: #4558)

@Avasam
Copy link
Contributor

Avasam commented Sep 30, 2024

CI failure looks completely unrelated, I got the same thing here: https://github.com/pypa/setuptools/actions/runs/11113018762/job/30876386043?pr=4556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasam Avasam Avasam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @Avasam