-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression from 7.x: unable to install some libraries (e.g. setuptools_scm_git_archive, pikepdf) - version detected as 0.0 #727
Comments
I suspect this is related to #580 |
I suspect its related to entrypoint matching vs archive contents |
Same here, thanks for the bug report and workaround! See flathub/com.github.jeromerobert.pdfarranger@159f3c4 for an example on how to apply it on a flatpak build. Make sure you set the variable for the build of the affected package itself, in this case pikepdf. Setting it when building other packages depending on the affected package won't work. I was a bit confused by the fact that pip reported
The build of img2pdf reported pikepdf as version 0.0 which hints in the right direction. (Full flatpak build log) |
I suspect this can easily be fixed by having the built in git support also consume the 3rd party plugin data Im out of commission due to a cold for a few days |
Related issues pypa/setuptools-scm#727 #359 (cherry picked from commit bdd6939)
the bug is in https://github.com/pypa/setuptools_scm/blob/21e58d4ebd9aedc1477a5021b0370f66963c4341/src/setuptools_scm/git.py#L293-L296 as this code runs instead of the one from the git_archive plugin, the value is wrong the code should only use this if there is a node in the archival data |
…o-version-for-empty fix #727: correctly handle incomplete archivals from setuptools_scm_g…
Can someone verify that this is fixed with 7.0.4? I'm still seeing a similar issue and filed #735 for what I was seeing. |
I don't think 7.0.4 is released yet. |
Ah I must have gotten the version number mixed up. Even 7.0.3 is not out. Thanks. I will try using the git version in some testing and see what I get. Thanks. |
Looks like its merged in and awaiting release? |
According to the git log it is already fixed in 7.0.3 i.e. the changelog is wrong. Haven't tested it yet. |
Looks like 7.0.4 was just released on PyPI 3 hours ago. |
I can confirm it's fixed in 7.0.3. It would be nice if someone could fix the changelog. |
https://build.opensuse.org/request/show/1055978 by user dirkmueller + dimstar_suse - update to 0.8.3: * Workaround pypa/setuptools-scm#727 * Add support for Tesseravt 5 + Linux * Fix file descriptor leak (thanks to oda) * Make the dependency on setuptools_scm optional
The following works:
docker run -it python:3.9-alpine /bin/sh -c \ 'pip install setuptools_scm==6.4.2 && pip install --no-build-isolation setuptools_scm_git_archive==1.2 --no-binary :all:'
But fails when upgrading to 7.0.2:
docker run -it python:3.9-alpine /bin/sh -c \ 'pip install setuptools_scm==7.0.2 && pip install --no-build-isolation setuptools_scm_git_archive==1.2 --no-binary :all:'
Output:
The notable line in the output is:
A workaround I've found is to use this escape hatch: https://github.com/pypa/setuptools_scm/blob/f1f35bd0f20a983a919d73a646a2ad9a3e36d5d4/src/setuptools_scm/_overrides.py#L15-L20
The text was updated successfully, but these errors were encountered: