Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations #166

Closed
bhrutledge opened this issue May 3, 2020 · 2 comments · Fixed by #225
Closed

Add type annotations #166

bhrutledge opened this issue May 3, 2020 · 2 comments · Fixed by #225
Labels
enhancement

Comments

@bhrutledge
Copy link
Contributor

I've been working on adding type annotations to Twine (pypa/twine#231), and readmer_renderer is one of our imports that's missing type hints/stubs. Is there any interest in adding those, either in the source or to https://github.com/python/typeshed?

See also: https://mypy.readthedocs.io/en/stable/existing_code.html
@di
Copy link
Member

di commented May 3, 2020

Yes! In the source would be fine.

@di di added the enhancement label Jun 18, 2020
@miketheman miketheman mentioned this issue Mar 10, 2022
Merged
@di
Copy link
Member

di commented Mar 10, 2022

FYI @bhrutledge, @miketheman has created #225 to address this if you wanted to review.

@di di closed this as completed in #225 Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add types miketheman/readme_renderer
2 participants
@di @bhrutledge