Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedTuple → dataclass #1416

Merged
merged 1 commit into from
May 20, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 18, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Extends #1414, improving maintainability.

Test plan

Pass CI tests.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the NamedTuple_dataclass branch 2 times, most recently from 717267a to c794469 Compare May 18, 2024 13:55
Helps maintainability. For example, it can help use mutable default values
during class initialisation.
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review May 18, 2024 14:10
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit e32dbf8 into pypa:main May 20, 2024
11 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the NamedTuple_dataclass branch May 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants