Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After interrupted reinstall-all, one package is gone #966

Open
jaraco opened this issue Apr 9, 2023 · 2 comments
Open

After interrupted reinstall-all, one package is gone #966

jaraco opened this issue Apr 9, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jaraco
Copy link
Member

jaraco commented Apr 9, 2023

Describe the bug

While troubleshooting #965, I ran reinstall-all several times, first without --verbose, then with --verbose, then a few times more until I was able to get a clean output of the behavior. During at least one of those runs, I interrupted the operation. I didn't take note of the operation that was in progress and assumed it was safe to terminate a pipx operation. I've since closed my terminal, so I no longer have a meaningful record of what transpired, but I can confirm that the tox executable is missing as is the virtualenv in ~/.local/pipx/venvs.

It's possible I had tox installed with nothing else, so it's straightforward to reinstall with pipx install tox, but I don't recall if I had other state configured in that environment (injected packages, ...).

How to reproduce

I haven't yet attempted to reproduce it. I'd like to get feedback about the expected behavior first.

Expected behavior

pipx operations should be interrupt-safe (rolled back if cancelled) or should warn the user (maybe even prompt) if an irreversible operation has taken place but its replacement has been cancelled. Such a message should include state that is otherwise lost (what packages were injected in that pipx env).

@dukecat0 dukecat0 added the bug Something isn't working label Apr 14, 2023
@dukecat0
Copy link
Member

dukecat0 commented Jul 1, 2023

Example output for this:

➜  ~ pipx reinstall-all    
uninstalled epr-reader! ✨ 🌟 ✨
  installed package epr-reader 2.4.15, installed using Python 3.9.2
  These apps are now globally available
    - epr
done! ✨ 🌟 ✨
uninstalled semantra! ✨ 🌟 ✨
  installed package semantra 0.1.6, installed using Python 3.9.2
  These apps are now globally available
    - semantra
done! ✨ 🌟 ✨
uninstalled maturin! ✨ 🌟 ✨

^C

➜  ~ maturin
zsh: command not found: maturin

@jaraco jaraco changed the title After reinstall-all, tox is gone After interrupted reinstall-all, one package is gone Jul 13, 2023
@gaborbernat
Copy link
Contributor

PR welcome.

@gaborbernat gaborbernat added the help wanted Extra attention is needed label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants