Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff rule RUF100 #1400

Closed
DimitriPapadopoulos opened this issue May 12, 2024 · 0 comments · Fixed by #1401
Closed

Add ruff rule RUF100 #1400

DimitriPapadopoulos opened this issue May 12, 2024 · 0 comments · Fixed by #1401

Comments

@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented May 12, 2024 •
edited
Loading

How would this feature be useful?

RUF100 detects unused noqa directives.

$ ruff check --extend-select RUF100
src/pipx/__main__.py:11:28: RUF100 [*] Unused blanket `noqa` directive
src/pipx/venv_inspect.py:111:37: RUF100 [*] Unused `noqa` directive (unknown: `T484`)
Found 2 errors.
[*] 2 fixable with the `--fix` option.

Describe the solution you'd like

Fix issues reported by ruff check --extend-select RUF100 and add RUF100 to pyproject.toml.

Describe alternatives you've considered
@DimitriPapadopoulos DimitriPapadopoulos changed the title Add ruff rule RUF100 Add ruff rule RUF100 May 12, 2024
@DimitriPapadopoulos DimitriPapadopoulos changed the title Add ruff rule RUF100 Add ruff rule RUF100 May 12, 2024
@DimitriPapadopoulos DimitriPapadopoulos mentioned this issue May 12, 2024
Merged
1 task
@Gitznik Gitznik mentioned this issue May 28, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply ruff rule RUF100 DimitriPapadopoulos/pipx
1 participant
@DimitriPapadopoulos