Support Named Package Categories #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that no longer require it.
… because of this.
|
I believe what is remaining is to:
|
oz123
requested changes
Oct 1, 2022
| ): | ||
| """ | ||
| Executes the installation functionality. | ||
|
|
||
| """ | ||
| procs = queue.Queue(maxsize=1) |
There was a problem hiding this comment.
If the queue size is always 1 do we even need a queue?
|
@matteius tremendous job! As you stated, the docs are still missing. |
This was referenced Oct 6, 2022
oz123
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
Fixes #4745
Description
Named package categories have many potential use cases -- including installing pre-requisite installation packages, system specific platform lock sections, using a single Pipfile for many sub-projects, and so much more!
This is a full feature PR to support
--categoriesargument for most of the pipenv commands and code paths.Example usages:
Single Category
pipenv install six --catetgories prereqMultiple categories
pipenv install --categories="prereq packages"Lock and Uninstall
pipenv lock --categories="prereq dev-packages"pipenv uninstall six --categories prereq