Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored dependencies #3470

Closed
wants to merge 8 commits into from
Closed

Update vendored dependencies #3470

wants to merge 8 commits into from

Conversation

techalchemy
Copy link
Member

Update vendored dependency pins

- Update gitignore entries for mypy config
- Update release task to add version after bumping but before release
- Fixes #3326 (going forward at least)
- Split out patching from vendoring so it can be done as a separate step
  if needed
- Update patches to account for updated packages
- Fixes #3432
- Fixes #2757
- Fixes #3305
- Fixes #2914
- Fixes #3439
- Fixes #3422
- Fixes #3378
- Fixes #3376
- Fixes #3315

Signed-off-by: Dan Ryan <dan@danryan.co>
- Clean up test config and environment variable handling
- Unset env var changes performend by `pipenv run`
- Make `environments.is_in_virtualenv()` more dynamic -- read
  environment on the fly
- Split up tests on `pipenv run` to reduce complexity -- one test for
  global run (no virtualenv creation), one test for virtualenv creation
- Add `warn_in_virtualenv` call to `run` command, why doesn't click
  invoke this automatically?

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy added Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. Type: Release Blocker Must be resolved before the next release can be cut. labels Jan 22, 2019
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@willcl-ark
Copy link

@techalchemy are the any instructions available for building and installing pipenv from source on OSX? If so I'd be happy to test out your commits which you are making (which I think might solve my issues!) I did check in homebrew for the --HEAD option which some taps offer (which lets you take master GitHub branch for installation), but I didn't see it available for pipenv...

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy
Copy link
Member Author

@willcl-ark pip install -e git+https://github.com/pypa/pipenv.git@vendor/update#egg=pipenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Release Blocker Must be resolved before the next release can be cut. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants