Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crayons from pipenv in favor of click.styles #3741

Closed
PatrikKopkan opened this issue May 10, 2019 · 2 comments · Fixed by #5178
Closed

Remove crayons from pipenv in favor of click.styles #3741

PatrikKopkan opened this issue May 10, 2019 · 2 comments · Fixed by #5178
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Priority: Medium This item is medium priority and will be resolved whenever possible. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.

Comments

@PatrikKopkan
Copy link

Hi, I am trying to devendor packaged pipenv in Fedora. The reason is that it would be easier for us track and solve bugs, CVEs... etc.

I'm working on the pythonfinder package (not patched). It apparently uses the patched version of crayons in pipenv.

I want to ask if you are planning to move from patched crayons to upstream crayons, upstreaming your changes.

I see that the creator of crayons is also the pipenv's BDFL and pipenv uses 7 months old patched version of it.
The rationale listed is very vague: "Crayons is upgraded".

@frostming frostming added the Type: Question ❔ This is a question or a request for support. label May 13, 2019
@techalchemy
Copy link
Member

Hi, someone could upstream patches to crayons but it is definitely not very high priority. I also am not sure if they would be accepted. Kenneth also has mostly stepped back from the BDFL role. We could consider other options besides patching here, but it just isn't on the priority list right now so it would have to be done by someone in the community

@techalchemy techalchemy added help wanted Priority: Low This item is low priority and may not be looked at in the next few release cycles. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv. labels May 20, 2019
@oz123
Copy link
Contributor

oz123 commented Jan 23, 2022

The patches seem like issues fixes, but also black formatting.
I would vote for completely removing crayons since everything that can be done with crayons can be done with click.

@matteius matteius changed the title Question about patched crayons Remove crayons from pipenv in favor of click.styles Jun 16, 2022
@matteius matteius added Priority: Medium This item is medium priority and will be resolved whenever possible. Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. and removed help wanted Type: Question ❔ This is a question or a request for support. Priority: Low This item is low priority and may not be looked at in the next few release cycles. labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. Priority: Medium This item is medium priority and will be resolved whenever possible. Type: Vendored Dependencies This issue affects vendored dependencies within pipenv.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants