Skip to content

Commit d15485e

Browse files
committed
I think I used this to do this mornings release.
1 parent 50d9ce3 commit d15485e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tasks/release.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,12 @@ def _render_log(ctx=None, version=None):
5050
if ctx and not version:
5151
version = find_version(ctx)
5252

53+
# Towncrier expects --version to be a flag to show its own version
54+
# For setting the project version, we need to use a positional argument
5355
cmd = ["towncrier", "--draft"]
5456
if version:
55-
cmd.append(f"--name={version}") # Use --name instead of --version
57+
# Add version as a positional argument
58+
cmd.append(version)
5659

5760
rendered = subprocess.check_output(cmd).decode("utf-8")
5861
return rendered
@@ -79,7 +82,7 @@ def release(
7982
tag_content = _render_log(ctx, version)
8083
if dry_run:
8184
# Use the correct version when generating the draft
82-
ctx.run(f"towncrier --draft --name={version} > CHANGELOG.draft.md")
85+
ctx.run(f"towncrier --draft {version} > CHANGELOG.draft.md")
8386
log("would remove: news/*")
8487
log("would remove: CHANGELOG.draft.md")
8588
log("would update: pipenv/pipenv.1")
@@ -88,11 +91,11 @@ def release(
8891
if pre:
8992
log("generating towncrier draft...")
9093
# Use the correct version when generating the draft
91-
ctx.run(f"towncrier --draft --name={version} > CHANGELOG.draft.md")
94+
ctx.run(f"towncrier --draft {version} > CHANGELOG.draft.md")
9295
ctx.run(f"git add {get_version_file(ctx).as_posix()}")
9396
else:
9497
# Use the correct version when generating the changelog
95-
ctx.run(f"towncrier --name={version}")
98+
ctx.run(f"towncrier {version}")
9699
ctx.run(f"git add CHANGELOG.md news/ {get_version_file(ctx).as_posix()}")
97100
log("removing changelog draft if present")
98101
draft_changelog = pathlib.Path("CHANGELOG.draft.md")

0 commit comments

Comments
 (0)