Skip to content

Commit cb6cdb9

Browse files
authored
Merge pull request #4252 from pypa/bugfix/4229
Fix the broken update --outdated handler
2 parents dad1c20 + 5882286 commit cb6cdb9

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

news/4229.bugfix.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix a bug of ``pipenv update --outdated`` that can't print output correctly.

pipenv/core.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1812,7 +1812,10 @@ def do_outdated(pypi_mirror=None, pre=False, clear=False):
18121812
(pkg.project_name, pkg.parsed_version, pkg.latest_version)
18131813
for pkg in project.environment.get_outdated_packages()
18141814
}
1815-
reverse_deps = project.environment.reverse_dependencies()
1815+
reverse_deps = {
1816+
canonicalize_name(name): deps
1817+
for name, deps in project.environment.reverse_dependencies().items()
1818+
}
18161819
for result in installed_packages:
18171820
dep = Requirement.from_line(str(result.as_requirement()))
18181821
packages.update(dep.as_pipfile())
@@ -1842,9 +1845,9 @@ def do_outdated(pypi_mirror=None, pre=False, clear=False):
18421845
version = None
18431846
if name_in_pipfile:
18441847
version = get_version(project.packages[name_in_pipfile])
1845-
reverse_deps = reverse_deps.get(name_in_pipfile)
1846-
if isinstance(reverse_deps, Mapping) and "required" in reverse_deps:
1847-
required = " {0} required".format(reverse_deps["required"])
1848+
rdeps = reverse_deps.get(canonicalize_name(package))
1849+
if isinstance(rdeps, Mapping) and "required" in rdeps:
1850+
required = " {0} required".format(rdeps["required"])
18481851
if version:
18491852
pipfile_version_text = " ({0} set in Pipfile)".format(version)
18501853
else:

0 commit comments

Comments
 (0)