Clean up lint, add news fragment and address issue 6167

Author: matteius

README.md

@@ -78,10 +78,6 @@ For most users, we recommend installing Pipenv using `pip`:
 
     pip install --user pipenv
 
-Or, if you\'re using Fedora:
-
-    sudo dnf install pipenv
-
 Or, if you\'re using FreeBSD:
 
     pkg install py39-pipenv

news/6276.bugfix.rst

@@ -0,0 +1,13 @@
+Features & Bug Fixes
+-------------------
+- Refactored and simplified install routines, improving maintainability and reliability (#6276)
+  - Split install logic into smaller, focused functions.
+  - Eliminated Pipfile caching for now to prevent bugs and reduce complexity.
+  - Fixed edge cases with package category selection.
+  - Improved handling of VCS dependencies during updates, fixing when ref is a revision and not a branch.
+
+- Enhanced VCS URL handling with better environment variable support (#6276)
+  - More reliable expansion of environment variables in Git URLs.
+  - Better handling of authentication components in VCS URLs.
+  - Improved error messaging for missing environment variables.
+  - Fixed issue where Git reference could be dropped during relock.

tests/integration/test_install_vcs.py

@@ -1,11 +1,7 @@
 import os
-from unittest.mock import patch, Mock, MagicMock
 
 import pytest
 
-from pipenv.patched.pip._internal.vcs.git import Git
-from pipenv.utils import requirementslib
-
 
 @pytest.mark.basic
 @pytest.mark.install

tests/unit/test_vcs.py

@@ -1,5 +1,7 @@
-import pytest
 import os
+
+import pytest
+
 from pipenv.exceptions import PipenvUsageError
 from pipenv.utils.dependencies import (
     VCSURLProcessor,
@@ -169,7 +171,7 @@ def test_git_ssh_shorthand_format():
 
     # First test direct VCSURLProcessor
     processed = VCSURLProcessor.process_vcs_url(url)
-    assert f"git@github.com:org/repo.git" == processed
+    assert "git@github.com:org/repo.git" == processed
 
     # Then test requirement string generation
     _, _, req_str = install_req_from_pipfile("package-name", pipfile)
@@ -215,7 +217,7 @@ def test_ssh_protocol_variations():
     test_cases = [
         "git+ssh://git@${HOST}/${REPO}.git",
         "ssh://git@${HOST}/${REPO}.git",
-        f"git@${{HOST}}:${{REPO}}.git"
+        "git@${{HOST}}:${{REPO}}.git"
     ]
 
     os.environ.update({