Skip to content

Conversation

@webknjaz
Copy link
Member

No description provided.

@webknjaz webknjaz requested review from pradyunsg and uranusjr April 20, 2021 18:16
@webknjaz webknjaz force-pushed the docs/sphinx-parallelism branch from 817ded5 to aecc809 Compare April 20, 2021 18:20
@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 20, 2021
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz
Copy link
Member Author

Is version required here?

It's a nice-to-have boilerplate. Not mandatory but doesn't hurt either.

@pradyunsg
Copy link
Member

Let's drop it, because lying to Sphinx that this plugin is a builtin is unnecessary IMO.

@webknjaz
Copy link
Member Author

Let's drop it, because lying to Sphinx that this plugin is a builtin is unnecessary IMO.

Oh, I thought that this meant that it's in-tree

@webknjaz webknjaz force-pushed the docs/sphinx-parallelism branch from aecc809 to 92862e2 Compare April 20, 2021 20:36
@pradyunsg pradyunsg merged commit 9ae842b into pypa:main Apr 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip news Does not need a NEWS file entry (eg: trivial changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants