Disallow explicitly passing install-location-related arguments in --install-options #8556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current test depends on passing `--home` to `--install-option`. Since we would like that to fail, we need to use another argument. None of the other possible arguments have a visible side-effect, so we just write the provided arguments to a file and check that in the test.
Similar to our previous test refactoring, this removes the usage of `--home` from the test command. "Overriding" in the original test meant "placed after" in the command-line arguments, which makes sense because setuptools will use the last argument passed.
Since it no longer shows a deprecation warning, the previous name doesn't fit.
chrahunt
changed the title
chrahunt
added
the
type: maintenance
sbidoul
approved these changes
Jul 8, 2020
|
I assumed that was to make sure we do not forget to follow through on the warning. |
xavfernandez
approved these changes
Jul 9, 2020
Yes! The idea is that if we miss this, the release manager would be running the test suite after bumping the version and we'llccatch the missed-deprecation there. This was something I thought was documented in the release process but isn't! We should fix the docs. :) |
|
Thank you again for your time! Now hopefully we can clean some stuff up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts our deprecation warning into a hard failure.
Closes #7309.