Deprecate Python 3.4 #6123
Merged
Deprecate Python 3.4 #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
force-pushed
the
deprecate34
branch
2 times, most recently
from
258b876
to
5dd7bec
Compare
pradyunsg
reviewed
Jan 10, 2019
xavfernandez
force-pushed
the
deprecate34
branch
from
59d6b62
to
2700329
Compare
xavfernandez
commented
Jan 10, 2019
tests/lib/__init__.py
Outdated
| @@ -381,6 +381,9 @@ def pip(self, *args, **kwargs): | |||
| if (pyversion_tuple < (2, 7, 9) and | |||
| args and args[0] in ('search', 'install', 'download')): | |||
| kwargs['expect_stderr'] = True | |||
| # Python 3.4 is deprecated and we emit a warning on it. | |||
| if pyversion_tuple[:2] == (3, 4): | |||
There was a problem hiding this comment.
I could have made the script fixture depend on deprecated_python but wasn't sure it was worth it...
There was a problem hiding this comment.
It'll be cleaner IMO, since then we'll only need to update the tests to reflect deprecated versions in one place.
There was a problem hiding this comment.
Done, adding a deprecation warning for Python 2.7 should now be quite easy 🙄
auvipy
approved these changes
Jan 10, 2019
xavfernandez
force-pushed
the
deprecate34
branch
2 times, most recently
from
3619774
to
18ad3c2
Compare
pradyunsg
reviewed
Jan 11, 2019
pradyunsg
reviewed
Jan 11, 2019
pip usually emits a warning and tests have to be adapted
xavfernandez
force-pushed
the
deprecate34
branch
from
011309d
to
2f20217
Compare
|
Version bumped and text slightly updated to mention Python 3.4 end of life. |
xavfernandez
force-pushed
the
deprecate34
branch
from
2f20217
to
b268c67
Compare
pradyunsg
approved these changes
Jan 13, 2019
5 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.