Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --prefer-binary option in requirements file #7693

Closed
stevecj opened this issue Feb 5, 2020 · 3 comments · Fixed by #7996
Closed

Allow --prefer-binary option in requirements file #7693

stevecj opened this issue Feb 5, 2020 · 3 comments · Fixed by #7996
Labels
auto-locked Outdated issues that have been locked by automation C: requirement file Using `requirements.txt` type: feature request Request for a new feature

Comments

@stevecj
Copy link

stevecj commented Feb 5, 2020

  • Pip version: 20.0.2

It would be very nice to be able to specify the --prefer-binary option in a requirements file.

Per https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format, both --no-binary and --only-binary are supported, but not --prefer-binary. I tried it out to make sure the documentation was accurate, and it is.

ERROR: Invalid requirement: --prefer-binary
pip3: error: no such option: --prefer-binary
@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Feb 5, 2020
@pradyunsg pradyunsg added C: requirement file Using `requirements.txt` type: feature request Request for a new feature labels Feb 5, 2020
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Feb 5, 2020
@deveshks
Copy link
Contributor

deveshks commented Apr 7, 2020

Hi @pradyunsg

Can I take up this issue and file a PR?

I was looking at src.pip._internal.req.req_file.SUPPORTED_OPTIONS and saw that the prefix_binary cmdoptions is missing. I think adding it back should fix this PR.

Also I didn't find good examples on how can the --xx-binary options be used in a requirements file, so I can add it to perhaps as part of that PR.

@pradyunsg
Copy link
Member

@deveshks sounds about right, and separate PRs for the semi-related documentation update would be a good idea. :)

@deveshks
Copy link
Contributor

deveshks commented Apr 8, 2020

Hi @pradyunsg

I have created #7996 for the issue. Please take a look 😊

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: requirement file Using `requirements.txt` type: feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants