Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak fix for #6252 #6259

Closed
cjerdonek opened this issue Feb 12, 2019 · 3 comments · Fixed by #6260
Closed

Tweak fix for #6252 #6259

cjerdonek opened this issue Feb 12, 2019 · 3 comments · Fixed by #6260
Labels
auto-locked Outdated issues that have been locked by automation
Milestone
19.0

Comments

@cjerdonek
Copy link
Member

cjerdonek commented Feb 12, 2019 •
edited
Loading

I think my fix for #6252 (PR #6253) should be tweaked in a few ways before releasing 19.0.3 because I didn't have a full understanding of that code path before. I'll file a PR to show you what I have in mind. The things I think should be changed are--

  • The logged message should be a warning in both cases instead of error in one case.
  • The message text should be tweaked to clarify that this is not a total "failure" in the normal sense.
  • The command output should maybe be truncated. My concern is that it could create a wall of text situation for some people.

/cc @pradyunsg
@cjerdonek cjerdonek added this to the 19.0 milestone Feb 12, 2019
@cjerdonek cjerdonek mentioned this issue Feb 12, 2019
Merged
@cjerdonek
Copy link
Member Author

I posted PR #6260 for this.

@lock
Copy link

lock bot commented May 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2019
@cjerdonek
Copy link
Member Author

Testing locked status..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
19.0
Development

Successfully merging a pull request may close this issue.

Improve logging in the case of a failed legacy build. cjerdonek/pip
1 participant
@cjerdonek