Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate git clone #12949

Closed
1 task done
xiaoyaolangzhi opened this issue Sep 2, 2024 · 2 comments
Closed
1 task done

Accelerate git clone #12949

xiaoyaolangzhi opened this issue Sep 2, 2024 · 2 comments
Labels
resolution: no action When the resolution is to not do anything

Comments

@xiaoyaolangzhi
Copy link

xiaoyaolangzhi commented Sep 2, 2024

What's the problem this feature will solve?

Accelerate git clone.

Describe the solution you'd like

Accelerate git clone

Alternative Solutions

Add --depth=1 for git clone.
File: pip/_internal/vcs/git.py

        if verbosity <= 0:
            flags: Tuple[str, ...] = ("--quiet", "--depth=1")
        elif verbosity == 1:
            flags = ("--depth=1",)
        else:
            flags = ("--verbose", "--progress", "--depth=1")

Additional context

.

Code of Conduct

@xiaoyaolangzhi xiaoyaolangzhi added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Sep 2, 2024
@RonnyPfannschmidt
Copy link
Contributor

This has repeatedly been proposed

It breaks scm metadata and thus breaks build/install for quite some packages

@uranusjr
Copy link
Member

uranusjr commented Sep 2, 2024

Yeah we actually tried this before and had to revert due to packages relying on SCM metadata to build. I’ll close this issue. Feel free to raise further proposals if there are more concrete ideas on how to deal with the problem.

@uranusjr uranusjr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2024
@uranusjr uranusjr added resolution: no action When the resolution is to not do anything and removed type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Sep 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution: no action When the resolution is to not do anything
Projects
None yet
Development

No branches or pull requests

3 participants