sudo pip freeze output is corrupted by mercurial warnings reported on stderr

[ogrisel]

Steps to reproduce:

• hg clone a mercurial repo, for instance virtualkeyring with a non root user,
• run sudo pip install -e .,
• run sudo pip freeze.

The output of the command is corrupted as follows:

-e hg+Not trusting file /volatile/ogrisel/virtualkeyring/.hg/hgrc from untrusted user ogrisel, group ogrisel
Not trusting file /volatile/ogrisel/virtualkeyring/.hg/hgrc from untrusted user ogrisel, group ogrisel@Not trusting file /volatile/ogrisel/virtualkeyring/.hg/hgrc from untrusted user ogrisel, group ogrisel
Not trusting file /volatile/ogrisel/virtualkeyring/.hg/hgrc from untrusted user ogrisel, group ogrisel
90481d8904bfb94e63b82c86d79aa0cf6ad4ed40#egg=virtualkeyring-dev

instead of:

-e hg+http://bitbucket.org/ogrisel/virtualkeyring@90481d8904bfb94e63b82c86d79aa0cf6ad4ed40#egg=virtualkeyring-dev

[ogrisel]

The problem is caused by the fact that mercurial warnings reported on stderr should not be included in the parsed output of the command. This can be fixed by changing pip.util.call_process to avoid sharing the same buffer for stderr and stdout, at least for the mercurial commands.

[ogrisel]

This bug is causing any saltstack state that uses the pip module to fail with the following traceback:

[INFO    ] Executing command '/usr/local/bin/pip2 freeze' in directory '/volatile/ogrisel'
[ERROR   ] Can't parse line '## FIXME: could not find svn URL in dependency_links for this package:'
XXX:hg+Not trusting file /volatile/ogrisel/virtualkeyring/.hg/hgrc from untrusted user ogrisel, group ogrisel
Traceback (most recent call last):
  File "/usr/bin/salt-call", line 11, in <module>
    salt_call()
  File "/usr/lib/pymodules/python2.6/salt/scripts.py", line 76, in salt_call
    client.run()
  File "/usr/lib/pymodules/python2.6/salt/cli/__init__.py", line 265, in run
    caller.run()
  File "/usr/lib/pymodules/python2.6/salt/cli/caller.py", line 132, in run
    ret = self.call()
  File "/usr/lib/pymodules/python2.6/salt/cli/caller.py", line 73, in call
    ret['return'] = func(*args, **kwargs)
  File "/usr/lib/pymodules/python2.6/salt/modules/pip.py", line 634, in list_
    version, name = line.split('#egg=')
ValueError: need more than 1 value to unpack

[pradyunsg]

Could someone check if this is still an issue?

[cjerdonek]

I finished proposing a PR to address this issue: PR #6339. I'm hoping it can be part of the 19.1 release.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.