Skip to content

Commit

Permalink
Build pep 517 requirements when installing packages
Browse files Browse the repository at this point in the history
  • Loading branch information
seppeljordan committed Sep 22, 2019
1 parent 1515407 commit f44da3b
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/pip/_internal/commands/install.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

# The following comment should be removed at some point in the future.
# It's included for now because without it InstallCommand.run() has a
# couple errors where we have to know req.name is str rather than
Expand Down Expand Up @@ -103,7 +102,7 @@ def check_binary_allowed(req):
# type: (InstallRequirement) -> bool
canonical_name = canonicalize_name(req.name)
allowed_formats = format_control.get_allowed_formats(canonical_name)
return "binary" in allowed_formats
return "binary" in allowed_formats or req.use_pep517

return check_binary_allowed

Expand Down Expand Up @@ -392,9 +391,9 @@ def run(self, options, args):
modifying_pip=modifying_pip
)

check_binary_allowed = get_check_binary_allowed(
finder.format_control
)
binary_allowed_from_format_control =
check_binary_allowed = get_check_binary_allowed(finder.format_control)

# Consider legacy and PEP517-using requirements separately
legacy_requirements = []
pep517_requirements = []
Expand Down

0 comments on commit f44da3b

Please sign in to comment.