Use metadata['name'] to get requirement name

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
pypa · May 30, 2022 · 7cdc1aa · 7cdc1aa
1 parent 63071d4
commit 7cdc1aa
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/pip/_internal/commands/install.py b/src/pip/_internal/commands/install.py
@@ -354,14 +354,15 @@ def run(self, options: Values, args: List[str]) -> int:
             )
 
             if options.dry_run:
-                items = [
-                    f"{item.name}-{item.metadata['version']}"
-                    for item in sorted(
-                        requirement_set.all_requirements, key=lambda x: str(x.name)
+                would_install_items = sorted(
+                    (r.metadata["name"], r.metadata["version"])
+                    for r in requirement_set.all_requirements
+                )
+                if would_install_items:
+                    write_output(
+                        "Would install %s",
+                        " ".join("-".join(item) for item in would_install_items),
                     )
-                ]
-                if items:
-                    write_output("Would install %s", " ".join(items))
                 return SUCCESS
 
             try: